chore(ci): add sanity check for filling benchmark tests#1779
Merged
danceratopz merged 2 commits intoethereum:forks/osakafrom Nov 13, 2025
Merged
chore(ci): add sanity check for filling benchmark tests#1779danceratopz merged 2 commits intoethereum:forks/osakafrom
danceratopz merged 2 commits intoethereum:forks/osakafrom
Conversation
Member
Author
|
The |
spencer-tb
approved these changes
Nov 12, 2025
Contributor
spencer-tb
left a comment
There was a problem hiding this comment.
LGTM! Couple small things.
8 tasks
marioevz
approved these changes
Nov 12, 2025
Member
marioevz
left a comment
There was a problem hiding this comment.
LGTM, the current failing CI should be fixed on rebase.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1779 +/- ##
============================================
Coverage 86.08% 86.08%
============================================
Files 743 743
Lines 44072 44072
Branches 3891 3891
============================================
Hits 37938 37938
Misses 5656 5656
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9a26621 to
c835893
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds a test env to
toxand a corresponding CI job to sanity check filling benchmark tests withevmone.🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.All: Considered adding an entry to CHANGELOG.md.skippedCute Animal Picture